GH-45398: [CI][Dev][Ruby] Add Ruby lint#45417
Merged
Merged
Conversation
|
|
Collaborator
Author
|
This PR relates to Ruby. @kou Please check this too. |
kou
reviewed
Feb 3, 2025
| ( | ||
| ?^dev/tasks/homebrew-formulae/.*\.rb$| | ||
| ) | ||
| files: .*\.rb$ |
Collaborator
Author
There was a problem hiding this comment.
Without this part and if the line width is 90, the pre-check claims the following
As we discussed on this #45403 (comment),
we need to exclude homebrew formulae. So, I added this part.
diff --git a/dev/tasks/homebrew-formulae/apache-arrow.rb b/dev/tasks/homebrew-formulae/apache-arrow.rb
index caf82b8db..01611d17b 100644
--- a/dev/tasks/homebrew-formulae/apache-arrow.rb
+++ b/dev/tasks/homebrew-formulae/apache-arrow.rb
@@ -110,7 +110,8 @@ class ApacheArrow < Formula
return 0;
}
EOS
- system ENV.cxx, "test.cpp", "-std=c++17", "-I#{include}", "-L#{lib}", "-larrow", "-o", "test"
+ system ENV.cxx, "test.cpp", "-std=c++17", "-I#{include}", "-L#{lib}", "-larrow",
+ "-o", "test"
system "./test"
end
end
Member
There was a problem hiding this comment.
dev/tasks/homebrew-formulae/*.rb should be excluded by exclude not files.
Collaborator
Author
There was a problem hiding this comment.
I'm not familiar pre-commit configuration. I thought you commented exclude part. But you commented about the files part? If so, It seems OK to delete that part.
Do you mean this?
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 8dcbeaece..cc46728b0 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -152,7 +152,6 @@ repos:
(
?^dev/tasks/homebrew-formulae/.*\.rb$|
)
- files: .*\.rb$
- repo: https://github.com/cheshirekow/cmake-format-precommit
rev: v0.6.13
hooks:
Collaborator
Author
There was a problem hiding this comment.
Removed files part. It seems to work well.
pre-commit run --verbose --all-files --color=always --show-diff-on-failure ruby-format
Ruby Format..............................................................Passed
- hook id: rubocop
- duration: 1.66s
Inspecting 84 files
....................................................................................
84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................
84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................
84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................
84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................
84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................
84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................
84 files inspected, no offenses detected
Inspecting 77 files
.............................................................................
77 files inspected, no offenses detected
github-actions
Bot
added
awaiting changes
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
github-actions
Bot
added
awaiting change review
github-actions
Bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6305c6e. There were 8 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Multiple users are developing Ruby codes. Adding Ruby Lint helps keep the same style.
What changes are included in this PR?
Add Ruby Lint. (Rubocop)
Are these changes tested?
Yes.
Are there any user-facing changes?
No.